Skip to content

Only wipe user content between tests #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 11, 2025

Conversation

miguelgrinberg
Copy link
Contributor

@miguelgrinberg miguelgrinberg commented Apr 1, 2025

This reduces the buildkite build time.

@miguelgrinberg
Copy link
Contributor Author

@pquentin WDYT?

@miguelgrinberg miguelgrinberg marked this pull request as ready for review April 2, 2025 14:58
@pquentin
Copy link
Member

pquentin commented Apr 2, 2025

Sounds good! Should we clean up is_xpack?

@miguelgrinberg miguelgrinberg requested a review from pquentin April 9, 2025 13:00
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good! Do you want to remove all dead code in this PR or as a follow-up? I'm thinking of all the unused wipe_ and wait_for_ functions.

@miguelgrinberg miguelgrinberg merged commit b45f50e into elastic:main Apr 11, 2025
16 checks passed
@miguelgrinberg miguelgrinberg deleted the dont-wipe-xpack branch April 11, 2025 15:13
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
* Only wipe user content between tests

* wipe data streams

* do not wipe component templates

* remove all references to unused is_xpack variable

* remove dead code

* remove unused imports

(cherry picked from commit b45f50e)
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
* Only wipe user content between tests

* wipe data streams

* do not wipe component templates

* remove all references to unused is_xpack variable

* remove dead code

* remove unused imports

(cherry picked from commit b45f50e)
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
* Only wipe user content between tests

* wipe data streams

* do not wipe component templates

* remove all references to unused is_xpack variable

* remove dead code

* remove unused imports

(cherry picked from commit b45f50e)
miguelgrinberg added a commit that referenced this pull request Apr 11, 2025
* Only wipe user content between tests

* wipe data streams

* do not wipe component templates

* remove all references to unused is_xpack variable

* remove dead code

* remove unused imports

(cherry picked from commit b45f50e)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit that referenced this pull request Apr 11, 2025
* Only wipe user content between tests

* wipe data streams

* do not wipe component templates

* remove all references to unused is_xpack variable

* remove dead code

* remove unused imports

(cherry picked from commit b45f50e)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit that referenced this pull request Apr 11, 2025
* Only wipe user content between tests

* wipe data streams

* do not wipe component templates

* remove all references to unused is_xpack variable

* remove dead code

* remove unused imports

(cherry picked from commit b45f50e)

Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants